Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request support for boost::span #1024

Open
Arsennnic opened this issue Jul 9, 2024 · 2 comments
Open

Request support for boost::span #1024

Arsennnic opened this issue Jul 9, 2024 · 2 comments

Comments

@Arsennnic
Copy link

I use boost::span as an alternative to std::span since I'm limited to C++17. boost::span has been introduced in Boost core since Boost-1.78, which is a compatible implementation of std::span.

Would you please and the support for boost::span?

Alternatively, would you mind if I refer to the code in <highfive/span.hpp>, implement this feature by myself, and open a pull request?

@1uc
Copy link
Collaborator

1uc commented Jul 10, 2024

Thank you, nice idea. We implemented it in #1025 but since boost::span is a very recent addition, the Boost version installed in the CI image (and I believe commonly on Ubuntu) is too old, i.e. v71.

Finishing the implementation would require splitting boost.hpp. Then setting up special CI to check against more modern versions of boost and finally make the automated tests aware of the boost version available so the can avoid testing boost::span iff it's not available.

You're likely better off forking or submoduling a particular SHA until we can finish the rest.

@Arsennnic
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants