Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep main Apache software license intact and mention the modelDB and Zenodo in the examples directory #206

Closed
anilbey opened this issue Aug 17, 2024 · 1 comment

Comments

@anilbey
Copy link
Contributor

anilbey commented Aug 17, 2024

This is mentioned by the AEiC of JOSS
openjournals/joss-reviews#7026 (comment)

BlueCelluLab does not depend on any of those licensed morphology or MOD files to be installed and run.

The MOD and morphologies are not even part of the package resources.
https://github.com/BlueBrain/BlueCelluLab/blob/fe4baed5db1cd3df85012e22e3625fb0646c5b5b/MANIFEST.in

Only the example directories and test directories show its applicability using those files.

So I suggest this commit can be reverted so that the software will have the original Apache license text
baebfcb

And then 2 LICENSE files can be created inside the /examples and /tests to acknowledge where the test and examples data/code (morph and MOD) comes from.

@ilkilic
Copy link
Contributor

ilkilic commented Aug 20, 2024

addressed in #208

@ilkilic ilkilic closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants