Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Periodicity to Consolidate Financial Statements and Cost Center Financial Statements and Added Variance feature to Consolidated Financial Statements #1793

Merged
merged 14 commits into from
Nov 23, 2021
Merged

feat: Added Periodicity to Consolidate Financial Statements and Cost Center Financial Statements and Added Variance feature to Consolidated Financial Statements #1793

merged 14 commits into from
Nov 23, 2021

Conversation

imdadhussain
Copy link

@imdadhussain imdadhussain commented Oct 26, 2021 •
edited
Loading

Task ID: https://bloomstack.com/desk#Form/Task/TASK-2021-00395

Screenshot/ GIFS

Periodicity GIF
period

Compare with Company Variance (A-B)GIF
varaince

Profit and losses GIF
profit and losses

Cost Center Financial Statement GIF
cost center

workflow:

  1. Added Period List for balance_sheet_data. which call get_data and added the period key and company key
  2. Added company + Period Key for get_columns
  3. company + period key and data generated by company + Period Key will append into data like above
  4. Added and changes to get_profit_and_losses_data which call get_data and added period key and company in data as shown in GIF.
  5. Made same changes for Cash Flow.
  6. Made changes in Cost Center Financial Statement to make work as Consolidated Financial Statement because same method are in these and also attached Gif.

@neilLasrado
Copy link
Member

@imdadhussain what's going on with this? The PR is in draft since 12 Days!

@imdadhussain imdadhussain marked this pull request as ready for review November 10, 2021 11:15
@imdadhussain
made change for profit and losses and cash flow for consolidated stat…
1d82179 
…ement and also made some changes in cost center statement to work the same.
@imdadhussain imdadhussain changed the title single company consolidated financial statement report company consolidated financial statement report and cost center and variance Nov 10, 2021
@imdadhussain
Copy link
Author

@imdadhussain what's going on with this? The PR is in draft since 12 Days!

@imdadhussain what's going on with this? The PR is in draft since 12 Days!

@neilLasrado just created PR for reference for @vishdha

@vishdha vishdha changed the title company consolidated financial statement report and cost center and variance feat: Added Periodicity to Consolidate Financial Statements and Cost Center Financial Statements and Added Variance feature to Consolidated Financial Statements Nov 10, 2021
@neilLasrado
Copy link
Member

@vishdha please review this

sahil28297
sahil28297 approved these changes Nov 23, 2021
View reviewed changes
Copy link

@sahil28297 sahil28297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging this as it has been tested locally by @vishdha

@sahil28297 sahil28297 merged commit e1ccc60 into Bloomstack:oct-sprint-1 Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahil28297 sahil28297 sahil28297 approved these changes

@vishdha vishdha vishdha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imdadhussain @neilLasrado @vishdha @sahil28297