Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve some and commented some test case and fixed patch test #1792

Merged
merged 4 commits into from
Oct 26, 2021
Merged

fix: resolve some and commented some test case and fixed patch test #1792

merged 4 commits into from
Oct 26, 2021

Conversation

vishdha
Copy link

@vishdha vishdha commented Oct 25, 2021 •
edited
Loading

  • Fixed Test Cases
  • Fixed Patch Test

Commented some test case:
Leave Application:

  1. test_optional_leave
  2. test_ledger_entry_creation_on_intermediate_allocation_expiry

Salary Slip

  1. test_email_salary_slip

Sales Order

  1. test_update_child_qty_rate_perm

Stock Entry

  1. test_repack_with_additional_costs

@vishdha vishdha changed the title fix: resolve some and commented some test case fix: resolve some and commented some test case and fixed patch test Oct 25, 2021
sahil28297
sahil28297 suggested changes Oct 25, 2021
View reviewed changes
Copy link

@sahil28297 sahil28297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishdha can you add the list of test cases that you commented in the PR description as well as on the task so that we can re-visit it later

erpnext/hr/doctype/job_offer/test_job_offer.py Outdated Show resolved Hide resolved
@sahil28297 sahil28297 merged commit 1f27adb into Bloomstack:develop Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahil28297 sahil28297 sahil28297 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishdha @sahil28297