chore: added comments to purchase_receipt.py and stock_entry.py #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrwX
changed the title
hrwX
previously approved these changes
May 12, 2021
rvpasari
suggested changes
May 17, 2021
| @@ -217,6 +217,7 @@ def get_current_stock(self): | |||
| d.current_stock = bin and flt(bin[0]['actual_qty']) or 0 | |||
|
|
|||
| def update_batch_with_supplier(self): | |||
| # update batch doc with supplier if batch doc don't have supplier | |||
There was a problem hiding this comment.
This comment is pretty useless, it does nothing that the function header does not already explain.
| @@ -691,6 +691,7 @@ def update_stock_ledger(self): | |||
| self.make_sl_entries(sl_entries, self.amended_from and 'Yes' or 'No') | |||
|
|
|||
| def update_batch_with_customer_provided_item(self): | |||
| # update batch doc with provided by customer if batch doc don't have provided by customer | |||
There was a problem hiding this comment.
Specify that is is being done only when the stock entry is a "Material Receipt". Each of the "if" statements should have a comment before explaining the purpose of the cases. The logic of the function should be visible in the comments.
sahil28297
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: Asana