fix: rename "Cost Center Wise Financial Statements" Report to "Cost Center Financial Statements" Report #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrwX
previously requested changes
Apr 16, 2021
erpnext/accounts/report/cost_center_financial_statements/cost_center_financial_statements.js
Outdated
Show resolved
Hide resolved
erpnext/accounts/report/cost_center_financial_statements/cost_center_financial_statements.js
Outdated
Show resolved
Hide resolved
hitenshKharva
force-pushed
the
remove_wise_cost_financial_report
branch
2 times, most recently
from
4c55db6
to
4583433
Compare
hitenshKharva
force-pushed
the
remove_wise_cost_financial_report
branch
from
4583433
to
80b6083
Compare
rvpasari
previously approved these changes
Apr 17, 2021
rvpasari
reviewed
Apr 17, 2021
| "label": __("Cost Center"), | ||
| "fieldtype": "MultiSelectList", | ||
| get_data: function(txt) { | ||
| return frappe.db.get_link_options('Cost Center', txt, { |
There was a problem hiding this comment.
This is an interesting function, will discuss @hrwX
|
@hitenshKharva Did you delete the files for the existing "wise" report? I cannot see old files being deleted in this PR. |
hitenshKharva
force-pushed
the
remove_wise_cost_financial_report
branch
from
80b6083
to
bd35434
Compare
|
@sahil28297 I deleted files and tried to commit, Git shows files renamed. Therefore, I wrote a patch to delete the old files. I have committed deletion of files. Review it and let me know the changes. |
sahil28297
approved these changes
Apr 19, 2021
sahil28297
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref : Asana Task