Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream PRs 1391, 1290, 1389, 1397, 1399, 1400, 1348, 1402, 1274, 1394, 1404, 1062, 1401, 1373, 1403, 1398, 1405, 1396, 1406, 1410, 1409, 1411, 1412, 1414, 1413, 1415, 1417, 1390, 1416, 1422, 1424, 1395 #270

Merged
merged 109 commits into from
Oct 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
109 commits
Select commit Hold shift + click to select a range
747ada3
test: Silent noisy clang warnings about Valgrind code on macOS x86_64
hebasto Jun 4, 2023
cef3739
cmake, refactor: Use helper function instead of interface library
hebasto Jul 14, 2023
116d2ab
cmake: Set `ENVIRONMENT` property for examples on Windows
hebasto Jul 14, 2023
175db31
ci: Drop no longer needed `PATH` variable update on Windows
hebasto Jul 14, 2023
690b0fc
add missing group element invariant checks
theStack Jun 14, 2023
4e9661f
Add _fe_verify_magnitude (no-op unless VERIFY is enabled)
peterdettman Dec 5, 2021
49afd2f
Take use of _fe_verify_magnitude in field_impl.h
theStack Jul 13, 2023
173e8d0
Implement current magnitude assumptions
peterdettman Dec 5, 2021
ad15215
update max scalar in scalar_cmov_test and fix schnorrsig_verify exhau…
stratospher Jul 11, 2023
c7d0454
add verification for scalars
stratospher Jul 3, 2023
d23da6d
use secp256k1_scalar_verify checks
stratospher Jul 12, 2023
c83afa6
Tighten group magnitude limits
peterdettman Dec 5, 2021
b7c685e
Save _normalize_weak calls in group add methods
peterdettman Dec 5, 2021
a1bd497
refactor: take use of `secp256k1_scalar_{zero,one}` constants (part 2)
theStack Aug 1, 2023
1b13415
Merge bitcoin-core/secp256k1#1391: refactor: take use of `secp256k1_s…
jonasnick Aug 3, 2023
374e2b5
Merge bitcoin-core/secp256k1#1290: cmake: Set `ENVIRONMENT` property …
real-or-random Aug 3, 2023
a2f7ccd
ci: Run "Windows (VS 2022)" job on GitHub Actions
hebasto Aug 9, 2023
96294c0
Merge bitcoin-core/secp256k1#1389: ci: Run "Windows (VS 2022)" job on…
real-or-random Aug 9, 2023
5ee039b
ci: Remove "Windows (VS 2022)" task from Cirrus CI
hebasto Aug 9, 2023
f1774e5
ci, gha: Make MSVC job presentation more explicit
hebasto Aug 9, 2023
8d2960c
Merge bitcoin-core/secp256k1#1397: ci: Remove "Windows (VS 2022)" tas…
real-or-random Aug 9, 2023
c8d9914
ci, gha: Run "SageMath prover" job on GitHub Actions
hebasto Aug 14, 2023
8408dfd
Revert "ci: Run sage prover on CI"
hebasto Aug 14, 2023
ce765a5
Merge bitcoin-core/secp256k1#1399: ci, gha: Run "SageMath prover" job…
jonasnick Aug 15, 2023
db32a24
ctimetests: Use new SECP256K1_CHECKMEM macros also for ellswift
real-or-random Aug 15, 2023
9c91ea4
ci: Enable ellswift module where it's missing
real-or-random Aug 15, 2023
b2f6712
Merge bitcoin-core/secp256k1#1400: ctimetests: Use new SECP256K1_CHEC…
jonasnick Aug 16, 2023
eedd781
Merge bitcoin-core/secp256k1#1348: tighten group magnitude limits, sa…
real-or-random Aug 16, 2023
bb4efd6
tests: remove unwanted `secp256k1_fe_normalize_weak` call
siv2r Jan 4, 2022
54058d1
field: remove `secp256k1_fe_equal_var`
siv2r Jan 30, 2022
d62db57
ci: Use Homebrew's gcc in native macOS task
hebasto Aug 16, 2023
b327abf
Merge bitcoin-core/secp256k1#1402: ci: Use Homebrew's gcc in native m…
real-or-random Aug 16, 2023
8e54a34
ci, gha: Run "x86_64: macOS Ventura" job on GitHub Actions
hebasto Aug 16, 2023
5d8fa82
Merge bitcoin-core/secp256k1#1274: test: Silent noisy clang warnings …
real-or-random Aug 16, 2023
3545dc2
ci, gha: Run all MSVC tests on Windows natively
hebasto Aug 17, 2023
d78bec7
ci: Remove Windows MSVC tasks from Cirrus CI
hebasto Aug 17, 2023
3d05c86
Merge bitcoin-core/secp256k1#1394: ci, gha: Run "x86_64: macOS Ventur…
jonasnick Aug 17, 2023
b0886fd
ci, gha: Ensure only a single workflow processes `github.ref` at a time
hebasto Aug 17, 2023
4a24fae
ci: Remove "arm64: macOS Ventura" task from Cirrus CI
hebasto Aug 5, 2023
c2f6435
ci: Add comment about switching macOS to M1 on GHA later
real-or-random Aug 17, 2023
bcffeb1
Merge bitcoin-core/secp256k1#1404: ci: Remove "arm64: macOS Ventura" …
jonasnick Aug 17, 2023
de657c2
Merge bitcoin-core/secp256k1#1062: Removes `_fe_equal_var`, and unwan…
real-or-random Aug 17, 2023
060e32c
Merge bitcoin-core/secp256k1#1401: ci, gha: Run all MSVC tests on Win…
jonasnick Aug 17, 2023
dc55141
tests: simplify `random_fe_non_zero` (remove loop limit and unneeded …
theStack Aug 7, 2023
c45b7c4
refactor: introduce testutil.h (deduplicate `random_fe_`, `ge_equals_…
theStack Aug 17, 2023
0ba2b94
Merge bitcoin-core/secp256k1#1373: Add invariant checking for scalars
real-or-random Aug 18, 2023
48b1d93
Merge bitcoin-core/secp256k1#1403: ci, gha: Ensure only a single work…
jonasnick Aug 18, 2023
2b6f9cd
ci, gha: Add Windows jobs based on Linux image
hebasto Aug 17, 2023
d6281dd
ci: Remove Windows tasks from Cirrus CI
hebasto Aug 17, 2023
87d35f3
ci: Rename `cirrus.sh` to more general `ci.sh`
hebasto Aug 17, 2023
6b9507a
Merge bitcoin-core/secp256k1#1398: ci, gha: Add Windows jobs based on…
jonasnick Aug 18, 2023
ad3e65d
ci: Remove GCC build files and sage to reduce size of Docker image
real-or-random Aug 14, 2023
03c9e65
ci, gha: Add "x86_64: Linux (Debian stable)" GitHub Actions job
hebasto Aug 18, 2023
6617a62
ci: Remove "x86_64: Linux (Debian stable)" task from Cirrus CI
hebasto Aug 18, 2023
4ad4914
ci, gha: Add `retry_builder` Docker image builder
hebasto Aug 18, 2023
e10878f
ci, gha: Drop `driver-opts.network` input for `setup-buildx-action`
hebasto Aug 19, 2023
ef9fe95
ci: Drop no longer needed workaround
hebasto Aug 20, 2023
5373693
Merge bitcoin-core/secp256k1#1405: ci: Drop no longer needed workaround
real-or-random Aug 21, 2023
2e6cf9b
Merge bitcoin-core/secp256k1#1396: ci, gha: Add "x86_64: Linux (Debia…
real-or-random Aug 21, 2023
880be8a
ci: Move "i686: Linux (Debian stable)" from Cirrus to GiHub Actions
hebasto Aug 21, 2023
ea33914
ci: Move "s390x (big-endian): Linux..." from Cirrus to GitHub Actions
hebasto Aug 21, 2023
0a16de6
ci: Move "ARM32: Linux..." from Cirrus to GitHub Actions
hebasto Aug 21, 2023
7782dc8
ci: Move "ARM64: Linux..." from Cirrus to GitHub Actions
hebasto Aug 21, 2023
fc3dea2
ci: Move "ppc64le: Linux..." from Cirrus to GitHub Actions
hebasto Aug 21, 2023
6ee1455
Merge bitcoin-core/secp256k1#1406: ci, gha: Move more non-x86_64 task…
real-or-random Aug 22, 2023
ee1be62
ci: Use concurrency for pull requests only
hebasto Aug 22, 2023
26a9899
Merge bitcoin-core/secp256k1#1410: ci: Use concurrency for pull reque…
real-or-random Aug 23, 2023
c22ac27
ci: Move sanitizers task from Cirrus to GitHub Actions
hebasto Aug 23, 2023
d51fb0a
ci: Move "MSan" from Cirrus to GitHub Actions
hebasto Aug 23, 2023
61fc3a2
ci: Move "C++ -fpermissive..." from Cirrus to GitHub Actions
hebasto Aug 23, 2023
676ed8f
ci: Move "C++ (public headers)" from Cirrus to GitHub Actions
hebasto Aug 23, 2023
4d7fe60
Merge bitcoin-core/secp256k1#1409: ci: Move remained task from Cirrus…
real-or-random Aug 23, 2023
317a4c4
ci: Move `git config ...` to `run-in-docker-action`
hebasto Aug 23, 2023
cce0456
ci: Make repetitive command the default one
hebasto Aug 23, 2023
ea26b71
Merge bitcoin-core/secp256k1#1411: ci: Make repetitive command the de…
real-or-random Aug 24, 2023
c223d7e
ci: Switch macOS from Ventura to Monterey and add Valgrind
hebasto Aug 28, 2023
65c79fe
Merge bitcoin-core/secp256k1#1412: ci: Switch macOS from Ventura to M…
real-or-random Aug 29, 2023
6ebe7d2
ci/Dockerfile: Always use versioned clang packages
real-or-random Aug 30, 2023
4b8a647
ci/gha: Add ARM64 QEMU jobs for clang and clang-snapshot
real-or-random Aug 30, 2023
2f0d3bb
ci/Dockerfile: Warn if `ulimit -n` is too high when running Docker
real-or-random Aug 30, 2023
e78c7b6
ci/Dockerfile: Reduce size of Docker image further
real-or-random Aug 30, 2023
2635068
ci/gha: Let MSan continue checking after errors in all jobs
real-or-random Aug 30, 2023
727bec5
Merge bitcoin-core/secp256k1#1414: ci/gha: Add ARM64 QEMU jobs for cl…
real-or-random Sep 4, 2023
875b0ad
tests: remove unnecessary set_illegal_callback
jonasnick Jul 28, 2023
a1d52e3
tests: remove unnecessary test in run_ec_pubkey_parse_test
jonasnick Jul 28, 2023
f9b3889
ci: Update `actions/checkout` version
hebasto Sep 4, 2023
8659a01
ci: Add `release` job
hebasto Sep 4, 2023
0b4640a
Merge bitcoin-core/secp256k1#1413: ci: Add `release` job
real-or-random Sep 4, 2023
bd9d98d
doc: Align documented scripts with CI ones
hebasto Sep 4, 2023
b0f7bfe
doc: Do not mention soname in CHANGELOG.md "ABI Compatibility" section
hebasto Sep 4, 2023
d9a8506
changelog: Catch up in preparation of release
real-or-random Sep 4, 2023
1633980
release: Prepare for 0.4.0
real-or-random Sep 4, 2023
f8d7ea6
tests: Replace counting_illegal_callbacks with CHECK_ILLEGAL_VOID
jonasnick Jul 28, 2023
7030364
tests: add CHECK_ERROR_VOID and use it in scratch tests
jonasnick Jul 31, 2023
199d27c
Merge bitcoin-core/secp256k1#1415: release: Prepare for 0.4.0
jonasnick Sep 4, 2023
9b118bc
release cleanup: bump version after 0.4.0
jonasnick Sep 4, 2023
cbf3053
Merge bitcoin-core/secp256k1#1417: release cleanup: bump version afte…
real-or-random Sep 4, 2023
49be5be
Merge bitcoin-core/secp256k1#1390: tests: Replace counting_illegal_ca…
real-or-random Sep 4, 2023
b10ddd2
Merge bitcoin-core/secp256k1#1416: doc: Align documented scripts with…
jonasnick Sep 4, 2023
9f005c6
cmake: Install `libsecp256k1.pc` file
hebasto Sep 7, 2023
421d848
ci: Align Autotools/CMake `CI_INSTALL` directory names
hebasto Sep 7, 2023
4fd00f4
Merge bitcoin-core/secp256k1#1422: cmake: Install `libsecp256k1.pc` file
real-or-random Sep 12, 2023
d9d80fd
ci: Bump major versions for docker actions
hebasto Sep 12, 2023
ba9cb6f
Merge bitcoin-core/secp256k1#1424: ci: Bump major versions for docker…
real-or-random Sep 13, 2023
ee7aaf2
Merge bitcoin-core/secp256k1#1395: tests: simplify `random_fe_non_zer…
real-or-random Sep 14, 2023
775f5e2
Merge commits '1b13415d 374e2b54 96294c00 8d2960c8 ce765a5b b2f6712d …
jonasnick Sep 19, 2023
e9d522f
ci: turn on -zkp modules in macos-native job
jonasnick Oct 12, 2023
6a3aae8
group_parse: use secp256k1_memcmp_var instead of memcmp
jonasnick Oct 12, 2023
b41caaa
bppp: replace memcmp in tests with secp256k1_memcmp_var
jonasnick Oct 12, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
462 changes: 0 additions & 462 deletions .cirrus.yml

This file was deleted.

33 changes: 33 additions & 0 deletions .github/actions/install-homebrew-valgrind/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: "Install Valgrind"
description: "Install Homebrew's Valgrind package and cache it."
runs:
using: "composite"
steps:
- run: |
brew tap LouisBrunner/valgrind
brew fetch --HEAD LouisBrunner/valgrind/valgrind
echo "CI_HOMEBREW_CELLAR_VALGRIND=$(brew --cellar valgrind)" >> "$GITHUB_ENV"
shell: bash

- run: |
sw_vers > valgrind_fingerprint
brew --version >> valgrind_fingerprint
git -C "$(brew --cache)/valgrind--git" rev-parse HEAD >> valgrind_fingerprint
cat valgrind_fingerprint
shell: bash

- uses: actions/cache@v3
id: cache
with:
path: ${{ env.CI_HOMEBREW_CELLAR_VALGRIND }}
key: ${{ github.job }}-valgrind-${{ hashFiles('valgrind_fingerprint') }}

- if: steps.cache.outputs.cache-hit != 'true'
run: |
brew install --HEAD LouisBrunner/valgrind/valgrind
shell: bash

- if: steps.cache.outputs.cache-hit == 'true'
run: |
brew link valgrind
shell: bash
49 changes: 49 additions & 0 deletions .github/actions/run-in-docker-action/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
name: 'Run in Docker with environment'
description: 'Run a command in a Docker container, while passing explicitly set environment variables into the container.'
inputs:
dockerfile:
description: 'A Dockerfile that defines an image'
required: true
tag:
description: 'A tag of an image'
required: true
command:
description: 'A command to run in a container'
required: false
default: ./ci/ci.sh
runs:
using: "composite"
steps:
- uses: docker/setup-buildx-action@v3

- uses: docker/build-push-action@v5
id: main_builder
continue-on-error: true
with:
context: .
file: ${{ inputs.dockerfile }}
tags: ${{ inputs.tag }}
load: true
cache-from: type=gha

- uses: docker/build-push-action@v5
id: retry_builder
if: steps.main_builder.outcome == 'failure'
with:
context: .
file: ${{ inputs.dockerfile }}
tags: ${{ inputs.tag }}
load: true
cache-from: type=gha

- # Tell Docker to pass environment variables in `env` into the container.
run: >
docker run \
$(echo '${{ toJSON(env) }}' | jq -r 'keys[] | "--env \(.) "') \
--volume ${{ github.workspace }}:${{ github.workspace }} \
--workdir ${{ github.workspace }} \
${{ inputs.tag }} bash -c "
git config --global --add safe.directory ${{ github.workspace }}
${{ inputs.command }}
"
shell: bash
Loading