-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icons specifications #2
Comments
Is this actionable or just informative for issuers? Perhaps better to have this on the wiki and link to it from the README? |
rather than README it may be good to have it shown on https://assets.blockstream.info/register.html ? |
Not sure we want it public yet, currently we're allowing only few selected assets to have an icon. I'd have it as an issue template, but they changed format and I didn't have time to set it up. Wiki is good for now, then when we'll have a larger flow of issuers asking to add their icons, we'll have to set up a vetting process anyway |
We should specify post-processing for icons to ensure they are as small as possible and adhere to the relevant standards. The current icon set can be losslessly reduced in size by 17% (edit: see below), and contain artifacts like invalid color profiles which may prevent display with strict software. We should additionally specify that that EXIF data must be stripped. I suggest we give a pngcrush command line for users to run before uploading, and reject icons if running that command on the icon again changes it. |
Agreed.
AFAIU users won't be able to upload icons on their own (at least initially), someone from Blockstream will have to authorize and upload it through some management dashboard. So perhaps we could just apply (Note that unlike the other asset metadata, the asset icon isn't committed to in the issuance tx nor signed by the issuer public key. It is only signed in the assets registry git db repo with the registry PGP key.) |
@shesek This seems like a good idea, given we have issues with the download size in our wallets, especially over tor. After experimenting with pngcrush a bit , the files can actually be reduced by 43% with no visual loss detectable using:
Seems like there is nothing stopping us then :D |
We are embedding the icons in the application at the start and no longer downloading them until we can support downloading individual icons. We can certainly post this recommendation but the behavior in the future should mean the optimization will be less important since they won't need to download every icon. |
@allenpiscitello So far only iOS has implemented icon embedding I believe. Compiling in the compressed asset data has just been implemented in gdk rather than being re-implemented in all wallets and requiring other users to find their own solutions, it will be available in the next release 0.0.44. The gdk solution has several advantages over per-wallet changes, but nonetheless the icon data maximally compressed adds ~1MB to the wallet with only 30 icons so far available in the registry (~2.5 MB for iOS, until it switches to the more efficient gdk implementation).
There are privacy issues with downloading a subset, the wallets will need to either download all icons or download more than they need to to create an anonymity set most likely. Optimising the data before committing it to the registry will reduce the impact of the privacy mitigation/allow twice the anonymity set. Given we have to vet icons before committing I think we should run the png optimisation ourselves before we commit the icon. |
We plan to add thousands of icons, so the download all of them solution does not work. If someone is concerned about privacy, they can use Tor. |
Even more reason to optimise then! |
Icons specification for Asset Registry
Format
Size
Transparency and colors
Padding
L-BTC has some padding to the left and right, because height>width
USDt ha some padding above and below because width>height
The text was updated successfully, but these errors were encountered: