Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dex): correct history log page display issue #55

Merged
merged 7 commits into from
Dec 17, 2024
Merged

fix(dex): correct history log page display issue #55

merged 7 commits into from
Dec 17, 2024

Conversation

Benjtalkshow
Copy link
Contributor

@Benjtalkshow Benjtalkshow commented Dec 13, 2024 •
edited
Loading

Description

  • Style scrollbars to match the application’s design.
  • Enable horizontal scrolling for timestamp visibility.
  • Use tables instead of divs for a more semantic UI.

Extra

  • Moved constants data into constants/history.ts

Proof

Watch Video

Related Issue(s)

Closes #46

Checklist:

  • Read the contributing docs (if this is your first contribution)

  • Verified this is not a duplicate of any existing pull request

  • Performed a self-review of the code

  • Rebased to the last commit of the target branch (or merged it into my branch)

  • Linked the issues which this PR resolves

Kindly Review @Abeeujah

@Oshioke-Salaki
Copy link
Collaborator

Table content should always be between the blue images at the top and bottom of the screen just like in the desktop version.

@Oshioke-Salaki
Copy link
Collaborator

Screenshot 2024-12-16 at 17 52 34 Fix irregularities in the footer and header images. It seems to repeat on desktop screens

@princeibs
Copy link
Collaborator

Screenshot 2024-12-16 at 17 52 34 Fix irregularities in the footer and header images. It seems to repeat on desktop screens

@Benjtalkshow

@Benjtalkshow
Copy link
Contributor Author

Screenshot 2024-12-16 at 17 52 34 Fix irregularities in the footer and header images. It seems to repeat on desktop screens

@Benjtalkshow

Alright

@Oshioke-Salaki
Copy link
Collaborator

please fix conflicts

@Benjtalkshow
Copy link
Contributor Author

Table content should always be between the blue images at the top and bottom of the screen just like in the desktop version.

I have done this

@Benjtalkshow
Copy link
Contributor Author

Screenshot 2024-12-16 at 17 52 34 Fix irregularities in the footer and header images. It seems to repeat on desktop screens

But i dont understand this correction. Can you explain it more?

@Benjtalkshow
Copy link
Contributor Author

@Oshioke-Salaki
@princeibs

  • Fix conflict
  • Place table between the header and footer images
  • Fix irregularities in footer and header image (remove duplicate image div for bg-main-bg)

@Utilitycoder Utilitycoder merged commit 33cba27 into BlockheaderWeb3-Community:main Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dex History Log Page
4 participants
@Benjtalkshow @Oshioke-Salaki @princeibs @Utilitycoder