Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In exercise 16, instructions and code editor warning tell user to do different things #20

Open
R-V-S opened this issue Jul 12, 2016 · 2 comments

Comments

@R-V-S
Copy link

R-V-S commented Jul 12, 2016

The exercise advises the user to create this selector:
div.float-left { float: left; }

... which causes a warning in the code editor which says that the element is over-qualified, just use .float-left:

image

Not a big deal, but I imagine a user might be confused about why the workshop is telling them to do 2 different things.

Also in this exercise, 2 other warnings pop up about the repercussions of using padding & border along with width. It's a great warning, and it makes sense to introduce the user to this warning before introducing box-sizing... but maybe there could be a little parenthetical note in the exercise instructions telling the user to ignore the warning for now, and that it's just a warning (some users might not be familiar with the icon and might mistake it for an error symbol).

image

@getaaron
Copy link
Contributor

@mikesjewett @stanidesis This is the second issue related to these warnings. Do you think they're helpful? Should we just turn them off?

@getaaron
Copy link
Contributor

(Thanks, @R-V-S - agree about the second warning)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants