Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js v6: v8::ObjectTemplate::Set() with non-primitive values is deprecated #192

Closed
uzysjung opened this issue Jun 9, 2017 · 2 comments

Comments

@uzysjung
Copy link

uzysjung commented Jun 9, 2017


$ node --version
v6.9.1

$ node -e 'require("node-rdkafka")'
==== C stack trace ===============================

 1: v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute)
 2: NodeKafka::KafkaConsumer::Init(v8::Local<v8::Object>)
 3: Init(v8::Local<v8::Object>, v8::Local<v8::Object>)
 4: node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&)
 5: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))
 6: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>)
 7: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*)
 8: 0x19dc4c2092a7
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

OS Version Mac 10.11.5(15F34)

Ref. nodejs/node#6216 and nodejs/node#6228 — starting with Node.js v6, setting non-primitive values on FunctionTemplate and ObjectTemplate instances is discouraged (and triggers a stack trace). v7 will downright disallow it.

please let us know when you update it.

thanks

@uzysjung
Copy link
Author

After Node-gyp update it disappeared

@webmakersteve
Copy link
Contributor

After node-gyp update it disappeared? This looks like it would relate to nan. But glad it resolved itself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants