Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter messages by unread #41

Open
SQL-MisterMagoo opened this issue May 2, 2019 · 2 comments
Open

Filter messages by unread #41

SQL-MisterMagoo opened this issue May 2, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@SQL-MisterMagoo
Copy link
Collaborator

Add a button to only show unread messages

@SQL-MisterMagoo SQL-MisterMagoo added the enhancement New feature or request label May 2, 2019
@SQL-MisterMagoo SQL-MisterMagoo self-assigned this May 2, 2019
@SQL-MisterMagoo
Copy link
Collaborator Author

this is done, I'll just wait for Mark's PR to go through before I PR this as it does contain a tiny little bit of scss.

@SQL-MisterMagoo
Copy link
Collaborator Author

I've decided to hold off on this one as it's not that useful and to make it useful needs more work.

Currently, I was just filtering the list by unread, but that doesn't magically go back and fetch unread older messages.

There is an API call to get a list of unread messages, but if the list is long we will very quickly hit the API rate limit trying to fetch them individually.

So, what we probably want to do it get the list of unread, then start fetching messages from the oldest using the normal routine - but filtering along the way.
This is unlikely to hit the rate limit but will probably be slower (maybe?) and will use more bandwidth.
So it might be something we need to restrict on mobile (although as an option/setting because I know I wouldn't care about the bandwidth).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant