Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate subview mapping expressions #327

Open
Mobe91 opened this issue Jan 19, 2017 · 1 comment
Open

Validate subview mapping expressions #327

Mobe91 opened this issue Jan 19, 2017 · 1 comment
Assignees
@Mobe91
Labels
beginner possible component: entity-view kind: enhancement worth: low Implementing this has a low worth

Comments

@Mobe91
Copy link
Contributor

Mobe91 commented Jan 19, 2017

Subview mapping expressions only allow path / treat expressions. We should validate the expression and throw an expressive exception.
@beikov beikov self-assigned this Jan 20, 2017
@beikov beikov added this to the 1.2.0 milestone Jan 20, 2017
@beikov
Copy link
Member

beikov commented Feb 4, 2017

The implementation should be pretty simple, just run the PathTargetResolvingExpressionVisitor on the expression and throw an error if the target type is not a subtype of the subviews entity type.

@beikov beikov assigned Mobe91 and unassigned beikov Feb 4, 2017
@beikov beikov modified the milestones: 1.2.0, 1.3.0 Jan 28, 2018
@beikov beikov added the worth: high Implementing this has a high worth label Sep 20, 2020
@beikov beikov mentioned this issue Oct 18, 2020
Open
@beikov beikov modified the milestones: 1.6.0, 1.6.x May 16, 2021
@beikov beikov removed this from the 1.6.x milestone Nov 1, 2021
@beikov beikov added worth: low Implementing this has a low worth and removed worth: high Implementing this has a high worth labels Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mobe91 Mobe91

Labels
beginner possible component: entity-view kind: enhancement worth: low Implementing this has a low worth
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beikov @Mobe91