Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from electron:main #3

Open
wants to merge 3,284 commits into
base: main
Choose a base branch
from
Open

[pull] main from electron:main #3

wants to merge 3,284 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Aug 25, 2021

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@commit-lint
Copy link

commit-lint bot commented Aug 25, 2021

Features

Continuous Integration

Code Refactoring

Chore

Tests

Bug Fixes

Documentation

Contributors

codebytere, dsanders11, ckerr, aiddya, tr2-harada, miniak, zcbenz, brhenrique, erickzhao, wanted002, jkleinsc

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@mergify
Copy link

mergify bot commented Apr 15, 2022

@pull-request-quantifier[bot] is not allowed to run commands

This PR has 137834 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80898 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13186 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

2 similar comments

This PR has 137834 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80898 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13186 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137834 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80898 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13186 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

8 similar comments

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

11 similar comments

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

dsanders11 and others added 30 commits November 19, 2024 10:52
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.27.1 to 3.27.4.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@4f3212b...ea9e4e3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…44715)

Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action) from 1.27.0 to 2.0.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases)
- [Commits](slackapi/slack-github-action@37ebaef...485a9d4)

---
updated-dependencies:
- dependency-name: slackapi/slack-github-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…update (#44701)

Bumps the npm_and_yarn group with 1 update in the / directory: [cross-spawn](https://github.com/moxystudio/node-cross-spawn).
Bumps the npm_and_yarn group with 1 update in the /spec directory: [cross-spawn](https://github.com/moxystudio/node-cross-spawn).


Updates `cross-spawn` from 7.0.3 to 7.0.6
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

Updates `cross-spawn` from 7.0.3 to 7.0.6
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: cross-spawn
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build: rework header generation in Node.js

* build: fix patch location error

* fix: set --root-dir correctly
* fix: destroy url loader wrapper when JS env exits

* Revert "fix: destroy url loader wrapper when JS env exits"

This reverts commit 419151a.

* Revert "Revert "fix: destroy url loader wrapper when JS env exits""

This reverts commit 4b401b0.

* fix: double free of JSChunkedDataPipeGetter

* fix: crash on process exit after stream completes
)

* chore: reland "fix: utility process exit code for graceful termination"

This reverts commit 1cae73b.

* fix: exit code on posix when killed via api

* chore: fix code style
…ll_popup_view.h (#44705)

fix: AutofillPopup warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]

refactor: reduce #indclude scope in autofill_popup.h and autofill_popup_view.h
* fix: bugprone-narrowing-conversions warning in NativeImage::memory_usage_

- fix signed / unsigned math by using base/numerics/safe_conversions

- make memory_usage_ an int64_t so it can safely take the size_t
  returned by computeByteSize()

Warning fixed by this commit:

../../electron/shell/common/api/electron_api_native_image.cc:155:26: warning: narrowing conversion from 'size_t' (aka 'unsigned long') to signed type 'int32_t' (aka 'int') is implementation-defined [bugprone-narrowing-conversions]
  155 |       new_memory_usage = image_skia->bitmap()->computeByteSize();

* fix: bugprone-narrowing-conversions warnings in NativeImage::CreateFromBitmap()

`SkImageInfo::MakeN32()` and `SkBitmap::allocN32Pixels()` both take int
width and height args, but we were feeding them unsigned ints.

../../electron/shell/common/api/electron_api_native_image.cc:508:36: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
  508 |   auto info = SkImageInfo::MakeN32(width, height, kPremul_SkAlphaType);
      |                                    ^
../../electron/shell/common/api/electron_api_native_image.cc:508:43: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
  508 |   auto info = SkImageInfo::MakeN32(width, height, kPremul_SkAlphaType);
      |                                           ^
../../electron/shell/common/api/electron_api_native_image.cc:524:25: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
  524 |   bitmap.allocN32Pixels(width, height, false);
      |                         ^
../../electron/shell/common/api/electron_api_native_image.cc:524:32: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
  524 |   bitmap.allocN32Pixels(width, height, false);
      |                                ^
../../electron/shell/common/api/electron_api_native_image.cc:528:48: warning: narrowing conversion from 'double' to 'float' [bugprone-narrowing-conversions]
  528 |       gfx::ImageSkia::CreateFromBitmap(bitmap, scale_factor);
* chore: bump chromium in DEPS to 133.0.6836.0

* chore: bump chromium in DEPS to 133.0.6838.0

* chore: update patches

* 6006096: [Sync ESB] Integrate Chrome Toast UI

https://chromium-review.googlesource.com/c/chromium/src/+/6006096

* Confine enable_device_bound_sessions buildflag to //net

https://chromium-review.googlesource.com/c/chromium/src/+/6014679

* revert [api] Delete deprecated struct FastApiTypedArray

 https://chromium-review.googlesource.com/c/v8/v8/+/5982984
Also
https://chromium-review.googlesource.com/c/v8/v8/+/5979766/1

* fixup revert [api] Delete deprecated struct FastApiTypedArray

* Migrate remaining NOTREACHED()s in chrome/

https://chromium-review.googlesource.com/c/chromium/src/+/5998172

* [Reland][Extensions] Remove ExtensionHostDelegate::GetJavaScriptDialogManager()

https://chromium-review.googlesource.com/c/chromium/src/+/6020106

* Remove NOTREACHED_IN_MIGRATION()

https://chromium-review.googlesource.com/c/chromium/src/+/6021996

* Remove Lock screen apps [#8] : remove lock screen extension

https://chromium-review.googlesource.com/c/chromium/src/+/6005846

* Reland "Add CrashReporterClient::GetProductInfo(ProductInfo*)"

https://chromium-review.googlesource.com/c/chromium/src/+/6012631

* Ozone/Wayland: remove lacros specific window states

https://chromium-review.googlesource.com/c/chromium/src/+/6011215

* chore: bump chromium in DEPS to 133.0.6840.0

* chore: bump chromium in DEPS to 133.0.6841.0

* chore: bump chromium in DEPS to 133.0.6844.0

* implement virtual WebContents::CanUserEnterFullscreen

* OnSearchifyStateChange -> OnSearchifyStarted

* regen libc++ filenames

* chore: bump chromium in DEPS to 133.0.6846.0

* chore: update patches

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <[email protected]>
Co-authored-by: Samuel Maddock <[email protected]>
Bumps [mikefarah/yq](https://github.com/mikefarah/yq) from 4.44.3 to 4.44.5.
- [Release notes](https://github.com/mikefarah/yq/releases)
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt)
- [Commits](mikefarah/yq@bbdd974...bc5b54c)

---
updated-dependencies:
- dependency-name: mikefarah/yq
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fix: tooltips in WCO capton buttons
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
* refactor: use gdk_display_beep() to beep on Linux

* chore: make a stub declaration for gdk_display_beep()

* chore: remove unused file electron_gtk.sigs

* chore: remove unused #includes to make gn check happy
* fix: windows save dialog extension bug

* refactor: simplify firstSpec extraction

Co-authored-by: Charles Kerr <[email protected]>

* refactor: split when necessary

Co-authored-by: Sam Maddock <[email protected]>

---------

Co-authored-by: Charles Kerr <[email protected]>
Co-authored-by: Sam Maddock <[email protected]>
* fix: performance-no-automatic-move in GetLogFileName()

remove `const` from log_filename.

Warning fixed by this commit:

../../electron/shell/common/logging.cc:40:12: warning: constness of 'log_filename' prevents automatic move [performance-no-automatic-move]

* fix: performance-no-automatic-move in GetBundleResourcePath()

remove `const` from request_relative_path.

Warning fixed by this commit:

electron/shell/browser/extensions/electron_extensions_browser_client.cc:187:10: warning: constness of 'request_relative_path' prevents automatic move [performance-no-automatic-move]
…44743)

* fix: performance-inefficient-vector-operation warning in Clipboard::WriteFilesForTesting()

* fix: performance-inefficient-vector-operation warning in GetUploadedReports()
style: remove duplicate line in gn file
* fix: ensure context-menu emitted for draggable regions

* chore: address suggestions from review
fix: crash calling shell.readShortcutLink
…#44598)

* feat: add query-session-end event for Windows

* fix: remove debug line

* feat: notify with reason on session-end

* docs: add comments and return params

* docs: add same docs to the BrowserWindow

* fix: add shutdown reason if lParam == 0

* docs: remove 'force' word

* docs: revert multithreading.md change

* docs: add reasons documentation, reason variable renamed to reasons

* docs: improve 'shutdown' reason wording

* docs: reword with 'can be'

* fix: pass reasons by reference

* fix: use newer approach which expose reasons value directly on Event object

* docs: add escaping

* style: linter fixes

* fix: project now should compile

* fix: EmitWithoutEvent method added, EmitWithEvent moved to private again

* docs: typo fix

Co-authored-by: Sam Maddock <[email protected]>

* docs: dedicated WindowSessionEndEvent type created

* docs: better wording for session-end event description

Co-authored-by: Will Anderson <[email protected]>

---------

Co-authored-by: Sam Maddock <[email protected]>
Co-authored-by: Will Anderson <[email protected]>
* chore: remove unused local non-trivial variable relaunch_executable

became unused in June 2016 in 0d066de

* chore: only declare program_name local variable if used

We declared it everywhere but only used it on Windows

* chore: remove unused local non-trivial variable path from UnregisterXWindow

it became unused in 2020 by 72a0892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.