Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Use Extension instead of Convention #105

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

nvervelle
Copy link
Contributor

Use Extension instead of Convention because Convention is deprecated in gradle 8.x and will be removed in gradle 9.x

See gradle upgrade guide

@nvervelle
Copy link
Contributor Author

Hi @anderseknert , @irodzik , @radrys !

Is there any possibility to review/merge this PR ?

@irodzik
Copy link
Contributor

irodzik commented Dec 19, 2023

Hi @anderseknert , @irodzik , @radrys !

Is there any possibility to review/merge this PR ?

Will this change break existing setups?

@nvervelle
Copy link
Contributor Author

Hi @irodzik , I don't think it will break existing setups : extensions have been introduced in gradle 3.X, so I think it should work unless you have a very old gradle.

@irodzik irodzik merged commit fcd67af into Bisnode:master Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants