Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error message for defid-rpc-error #46

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

fuxingloh
Copy link
Contributor

What kind of PR is this?:

/kind chore

What this PR does / why we need it:

Current error message is not useful for debugging, especially worst if debugging with the logs from CI.

@defichain-bot defichain-bot added the kind/chore Non feature change label Mar 9, 2021
@github-actions
Copy link

github-actions bot commented Mar 9, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 102 B (0%) 10 ms (0%) 84 ms (+33.18% 🔺) 94 ms

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #46 (177e074) into main (e2366db) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   93.02%   92.98%   -0.05%     
==========================================
  Files          10       10              
  Lines         172      171       -1     
  Branches       19       19              
==========================================
- Hits          160      159       -1     
  Misses         12       12              
Impacted Files Coverage Δ
packages/testcontainers/src/chains/container.ts 87.23% <100.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2366db...6a8e063. Read the comment docs.

@fuxingloh fuxingloh force-pushed the fuxingloh/defid-rpc-error branch from 9b7db50 to 6a8e063 Compare March 9, 2021 09:13
@fuxingloh fuxingloh marked this pull request as ready for review March 9, 2021 09:25
@fuxingloh fuxingloh merged commit 00986ae into main Mar 9, 2021
@fuxingloh fuxingloh deleted the fuxingloh/defid-rpc-error branch March 9, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Non feature change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants