Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mining RPCs tests #318

Merged
merged 2 commits into from
May 31, 2021
Merged

Refactor mining RPCs tests #318

merged 2 commits into from
May 31, 2021

Conversation

jingyi2811
Copy link
Contributor

What kind of PR is this?:

/kind refactor

What this PR does / why we need it:

It’s getting very difficult to maintain side-effect and writing independent tests. Writing a clean and independent test is not easy, it requires a certain mastery with strong testing principles. Refactoring tests in jellyfish-api-core will allow us to have a cleaner testing culture.

Which issue(s) does this PR fixes?:

Fixes #295

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented May 31, 2021

Code Climate has analyzed commit 0a091f2 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

github-actions bot commented May 31, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 19.6 KB (0%) 393 ms (0%) 165 ms (+0.86% 🔺) 557 ms

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #318 (0a091f2) into main (ac5a53c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   97.04%   97.04%           
=======================================
  Files          91       91           
  Lines        2507     2507           
  Branches      318      318           
=======================================
  Hits         2433     2433           
  Misses         74       74           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac5a53c...0a091f2. Read the comment docs.

@jingyi2811 jingyi2811 marked this pull request as ready for review May 31, 2021 05:07
@fuxingloh fuxingloh enabled auto-merge (squash) May 31, 2021 05:18
@fuxingloh fuxingloh merged commit 2e93b73 into main May 31, 2021
@fuxingloh fuxingloh deleted the jimmy/refactor-mining-test branch May 31, 2021 05:20
eli-lim pushed a commit that referenced this pull request Mar 27, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…tall for DfTx (#318)
canonbrother pushed a commit that referenced this pull request Jun 1, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…tall for DfTx (#318)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor Non feature refactor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor all test in jellyfish-api-core to be independent
4 participants