fix(jellyfish-api-core): update testPoolSwap arguments #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamc1
requested review from
fuxingloh,
canonbrother and
ivan-zynesis
as code owners
This reverts commit 77daa0e.
❌ Deploy Preview for jellyfishsdk failed.
|
|
Code Climate has analyzed commit 01c9f40 and detected 0 issues on this pull request. View more on Code Climate. |
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 89.23% // Head: 91.70% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1856 +/- ##
==========================================
+ Coverage 89.23% 91.70% +2.47%
==========================================
Files 351 361 +10
Lines 10298 10473 +175
Branches 1301 1318 +17
==========================================
+ Hits 9189 9604 +415
+ Misses 1057 830 -227
+ Partials 52 39 -13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
shohamc1
requested review from
cwkang1998,
kodemon and
eli-lim
as code owners
cwkang1998
suggested changes
Nov 22, 2022
packages/jellyfish-api-core/__tests__/category/poolpair/testpoolswap.test.ts
Outdated
Show resolved
Hide resolved
fuxingloh
reviewed
Nov 22, 2022
fuxingloh
approved these changes
Nov 22, 2022
marktanrj
pushed a commit
that referenced
this pull request
Nov 22, 2022
<!-- Thanks for sending a pull request! --> #### What this PR does / why we need it: Exposes the path and verbose arguments on `testpoolswap`. Removes the defunct UTXO argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Exposes the path and verbose arguments on
testpoolswap. Removes the defunct UTXO argument.