Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobalPrefix should be wildcard and not be static #2000

Open
fuxingloh opened this issue Jan 24, 2023 · 4 comments
Open

GlobalPrefix should be wildcard and not be static #2000

fuxingloh opened this issue Jan 24, 2023 · 4 comments
Labels

Comments

@fuxingloh
Copy link
Contributor

What would you like to be added:

https://github.com/JellyfishSDK/jellyfish/blob/8a5dfcf2059ce1a667d6fcff2589ac75899f9582/apps/whale-api/src/app.module.ts#L67-L72

Currently, setGlobalPrefix uses version set from config or default to package.json v{major}.{minor} with patch trimmed. We should use a dynamic wildcard like v*/{network} to allow for deployment where the version is not known ahead of time.

Why is this needed:

For flexible IAC where the version is not statically enforced by a running container — to allow easy dynamic routing. For example, we can reroute v3 traffic to v0 easily. Now we can't do it.

@fuxingloh fuxingloh added the kind/feature New feature request label Jan 24, 2023
@github-actions
Copy link

@fuxingloh: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the JellyfishSDK developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions github-actions bot added needs/triage Waiting for triage to be accepted needs/area Needs area label(s) labels Jan 24, 2023
@github-actions
Copy link

@fuxingloh: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the JellyfishSDK developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@fuxingloh
Copy link
Contributor Author

/triage accepted
/area apps
/apps whale-api playground-api

@github-actions github-actions bot added triage/accepted Triage has been accepted area/apps apps/playground-api apps/whale-api and removed needs/triage Waiting for triage to be accepted needs/area Needs area label(s) labels Jan 24, 2023
@fuxingloh
Copy link
Contributor Author

/priority important-soon

@github-actions github-actions bot added the priority/important-soon Will be important soon label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant