Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop mode #746

Open
39 of 41 tasks
thedoublejay opened this issue Aug 31, 2021 · 4 comments
Open
39 of 41 tasks

Desktop mode #746

thedoublejay opened this issue Aug 31, 2021 · 4 comments
Assignees
Labels
area/desktop design/in-progress Design in-progress kind/feature New feature request triage/accepted Triage has been accepted

Comments

@thedoublejay
Copy link
Contributor

thedoublejay commented Aug 31, 2021

What would you like to be added:

We would like to have a light wallet desktop app that can be installed on Windows, Mac and Linux. Light wallet means it doesn't need to run a full node (like our existing desktop wallet) but use APIs from whale to do transactions. As a first iteration, we will only support light mode but in the future we can have a full node version as well.

It should share state and architecture with the mobile app. The only difference would be in terms of UI state. While there are solutions out there to provide easier portability between mobile and desktop, it might cause more harm in the future. Features not existing, lots of hacks and gotcha to add (if desktop, if mobile etc.).

Acceptance Criteria:

Setup and Workflows

Features

@thedoublejay thedoublejay added the kind/feature New feature request label Aug 31, 2021
@defichain-bot defichain-bot added the needs/triage Waiting for triage to be accepted label Aug 31, 2021
@defichain-bot
Copy link
Contributor

@thedoublejay: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@defichain-bot defichain-bot added the needs/area Needs area label(s) label Aug 31, 2021
@defichain-bot
Copy link
Contributor

@thedoublejay: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@jtlntno-des jtlntno-des self-assigned this Aug 31, 2021
@thedoublejay thedoublejay added design/in-progress Design in-progress and removed needs/area Needs area label(s) needs/triage Waiting for triage to be accepted labels Sep 7, 2021
@thedoublejay thedoublejay self-assigned this Sep 7, 2021
@thedoublejay thedoublejay added this to the Design Preview milestone Sep 7, 2021
@thedoublejay thedoublejay added the triage/accepted Triage has been accepted label Sep 7, 2021
@defichain-bot defichain-bot added needs/triage Waiting for triage to be accepted needs/area Needs area label(s) labels Sep 7, 2021
@thedoublejay thedoublejay changed the title desktop mode Desktop mode - Main ticket Sep 16, 2021
@thedoublejay thedoublejay changed the title Desktop mode - Main ticket Desktop mode - Main issue Sep 16, 2021
@thedoublejay thedoublejay changed the title Desktop mode - Main issue Desktop mode Sep 16, 2021
@thedoublejay thedoublejay added area/desktop and removed needs/area Needs area label(s) needs/triage Waiting for triage to be accepted labels Sep 16, 2021
@defichain-bot defichain-bot added the needs/area Needs area label(s) label Sep 16, 2021
@thedoublejay thedoublejay removed the needs/area Needs area label(s) label Sep 16, 2021
@thedoublejay
Copy link
Contributor Author

@jtlntno-cake We would also want to put some disclaimer/copy on some parts of the app that it's a light wallet and there are differences between the full node wallet. Like:

  • No .dat file
  • No import/export or backup
  • Restore recovery words only from Mobile wallet
  • No snapshots
  • No syncing needed
  • No blockchain state

@jtlntno-des
Copy link

@thedoublejay here's a rough initial design for our responsive grid in desktop light wallet. As it stands, we have the minimum size of 768px (to cater for tablet-portrait) but we can have the default size as 1024px.

With this, we can start laying out the components as what we have from the mobile light wallet.

Let me know your thoughts or add comments on Figma.

@thedoublejay thedoublejay pinned this issue Oct 4, 2021
@thedoublejay thedoublejay unpinned this issue Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/desktop design/in-progress Design in-progress kind/feature New feature request triage/accepted Triage has been accepted
Projects
None yet
Development

No branches or pull requests

3 participants