Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace AsyncStorage with SecureStore for Wallet #318

Closed
fuxingloh opened this issue Jul 21, 2021 · 2 comments · Fixed by #337
Closed

Replace AsyncStorage with SecureStore for Wallet #318

fuxingloh opened this issue Jul 21, 2021 · 2 comments · Fixed by #337
Assignees
@ivan-zynesis
Labels
area/core area/wallet kind/feature New feature request triage/accepted Triage has been accepted

Comments

@fuxingloh
Copy link
Contributor

What would you like to be added:

https://docs.expo.io/versions/latest/sdk/securestore/

Why is this needed:

/area core wallet
/triage accepted
@fuxingloh fuxingloh added the kind/feature New feature request label Jul 21, 2021
@fuxingloh
Copy link
Contributor Author

/assign @ivan-zynesis since you just opened a PR for it.

Need to detect where SecuredStorage is enabled this is for pivot into Web.

@fuxingloh
Copy link
Contributor Author

fuxingloh commented Jul 21, 2021 •
edited
Loading

I also think we should store everything related to wallet in Secured Storage? E.g. Network is tied to Wallet.

@fuxingloh fuxingloh mentioned this issue Jul 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivan-zynesis ivan-zynesis

Labels
area/core area/wallet kind/feature New feature request triage/accepted Triage has been accepted
Projects
None yet
Milestone
No milestone
3 participants
@fuxingloh @ivan-zynesis @defichain-bot