Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utility - optimize cypress command #2679

Open
kyleleow opened this issue Apr 20, 2022 · 2 comments
Open

utility - optimize cypress command #2679

kyleleow opened this issue Apr 20, 2022 · 2 comments
Labels
area/e2e kind/chore Non feature change needs/priority Needs a priority label needs/triage Waiting for triage to be accepted

Comments

@kyleleow
Copy link
Contributor

What would you like to be added:

  • Refactor large API response data during cy.intercept() like token, LP, vaults or auctions into fixtures, helps in maintaining, reusability and keeping e2e test files lean
  • Modify cypress send token command to assert token to reflect in the UI after API is returned, right now we are always adding arbitrary waiting time (1s - 10s) for the token to update in the UI

Why is this needed:

  • QoL improvement
@kyleleow kyleleow added kind/chore Non feature change area/e2e labels Apr 20, 2022
@defichain-bot
Copy link
Contributor

@kyleleow: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@defichain-bot defichain-bot added needs/triage Waiting for triage to be accepted needs/priority Needs a priority label labels Apr 20, 2022
@defichain-bot
Copy link
Contributor

@kyleleow: Thanks for opening an issue, an appropriate priority will be added soon.

The priority labels can be added by foundation members by writing /priority [type] in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/e2e kind/chore Non feature change needs/priority Needs a priority label needs/triage Waiting for triage to be accepted
Projects
None yet
Development

No branches or pull requests

2 participants