-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tailwind
- throw error for invalid class name
#1044
Conversation
❌ Deploy Preview for wallet-defichain failed. 🔨 Explore the source changes: c756fc9 🔍 Inspect the deploy log: https://app.netlify.com/sites/wallet-defichain/deploys/61666606b8049d0007fcd675 |
Code Climate has analyzed commit c756fc9 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #1044 +/- ##
==========================================
+ Coverage 89.26% 89.41% +0.14%
==========================================
Files 164 165 +1
Lines 2991 3003 +12
Branches 618 619 +1
==========================================
+ Hits 2670 2685 +15
+ Misses 319 316 -3
Partials 2 2
Continue to review full report at Codecov.
|
✔️ Deploy Preview for mobile-wallet-preview ready! 🔨 Explore the source changes: c756fc9 🔍 Inspect the deploy log: https://app.netlify.com/sites/mobile-wallet-preview/deploys/6166660633dfda0008bccb9a 😎 Browse the preview: https://deploy-preview-1044--mobile-wallet-preview.netlify.app/ |
Build preview for DeFiChain Wallet is ready! Built with commit 7265d4c https://expo.io/@defichain/wallet?release-channel=pr-preview-1044 |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
@@ -48,7 +50,16 @@ const created = create({ ...styles, ...fonts }) | |||
* @param {...Argument[]} args | |||
*/ | |||
export function tailwind (...args: Argument[]): { [key: string]: string } { | |||
validateTailwindClass(classNames(args).split(' ')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is compiled and will not run on production mode or just debug mode only.
If this code section run in production, it will be too "expensive"?
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Which issue(s) does this PR fixes?:
Fixes #1002
Additional comments?:
Does not have an option to suppress exception based on environment
Developer Checklist: