Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daisy chaining code needs to be refined #237

Open
AugustT opened this issue Jul 20, 2021 · 3 comments
Open

Daisy chaining code needs to be refined #237

AugustT opened this issue Jul 20, 2021 · 3 comments

Comments

@AugustT
Copy link
Member

AugustT commented Jul 20, 2021

@FrancescaMancini has been exploring this

@AugustT
Copy link
Member Author

AugustT commented Jul 20, 2021

@FrancescaMancini Would you be able to put a bullet pointed list here of the issues you have been having that we can pick up in the future?

@FrancescaMancini
Copy link
Contributor

  • rslurm code to create job scripts was not optimal for daisy chaining; this is now partially fixed, but requires changing the submit.sh template and so it does not fit well with the pipeline for the runs that do not require daisy chaining
  • The first chain is run with sparta, which saves an object out, a sparta object containing all the elements expected (BUGoutput, model etc.); all other chains are run by the function daisy, which saves an object also called out, but this object is a list containing the JAGS object out so basically we end up with out$out. This created problems when the second chain was being updated (because you cannot recompile a list). I made a temporary fix, with a series of if statements but it would be better if the object out saved by daisy was the same as that saved by sparta.

@AugustT
Copy link
Member Author

AugustT commented Jul 26, 2021

Thanks. To the first point, I think you can supply the template as a character variable rather than a path. If so, the first point could be addressed by creating a function that returns your new template and passing that to the relevant argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants