Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional id to metrics #9

Open
burkmarr opened this issue Feb 6, 2023 · 0 comments
Open

Add optional id to metrics #9

burkmarr opened this issue Feb 6, 2023 · 0 comments

Comments

@burkmarr
Copy link
Collaborator

burkmarr commented Feb 6, 2023

To overcome a problem with highlighting (and transitions?) on charts where metrics can be dynamically added and removed, I added an optional id property to temporal chart. This is to uniquely id metric - the name of the property on which metric is based may not always be sufficient because more than one metric can be based on same property which is why code adds property index to property. But the indexes change as metrics are added/removed. Hence the need for unique ID under these circumstances.

This issue is to remind that the same fix might need to be added to other chart types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant