Disappearing uploaded picturess in Walk Data Entry - eBMS website

[CrisSevilleja]

The Hungarian coordinator (Indicia warehouse ID user 227047) has issues uploading pictures on the website for the transect visit.
He described the screenshot like this:

"#1 uploading the max. amount of 4 allowed pics through the opening transect walk data page;

#204 writting captions for the 4 uploaded pic, then click next to go to the section data (counts by spp.) upload pages.

#3 after finishing the sections data (counts by spp.) uploads, for all sections, I click back to the walk data page where the uploaded pics should be but they are not there anymore.

The same results if I do not go back but finish the upload = save the walk with all data (walk data+pics+sections (count) data >> and then I check this particular transect walk data later: pics disappeared.
If you check my transect walks, I attached pics with captions to every walk (!), still, if you look at the attached short screen capture, most of them are missing. Sometimes it works (there are some visits where the uploaded pics do appear.) uploaded through the ButterflyCount App do show up >> that is why I think that the problem is with the dedicated HuBMS walk entry page."

Related to access the pictures on the website, there is another related issue #720
@DavidRoy @JimBacon

[andrewvanbreda]

Hi @CrisSevilleja
I was just about to raise this, as I noticed this problem when doing my other work preparing the site to allow the latest iForm upgrades to work.
I have already investigated as part of this other work and the images do not seem to be saving to the database.
I will try to find out what is happening, as very bad situation if data not saving.

I have noticed it work in the situation where the Walk already exists, and the images are uploaded onto the existing walk.
I guess images uploaded in the app would probably work too.

It would be useful if you know if this used to work or not?

@DavidRoy I don't normally assign things to myself, but I will do so here as have already partially investigated it as part of my other task.

[DavidRoy]

Thanks @andrewvanbreda - go for it

[andrewvanbreda]

@DavidRoy @CrisSevilleja
Tricky one.
I thought it was the Warehouse at first, however John helped me determine it wasn't.
In the end I spotted a bug in the custom submission code for the form.
I have deployed a fix to live.

Unfortunately photos uploaded wouldn't have been saved, although ones from the app will be fine.
Also as noted, the problem doesn't affect samples if the sample was saved first, and photos were added during an edit after.
Other projects won't be affected unless they happen to use this custom submission code.
I think UKBMS is probably ok as I don't think the form has sample photos. I think same for SPRING, it doesn't use sample photos, however I will confirm that another day.

[andrewvanbreda]

I have also deployed the same fix to UKBMS (although that doesn't use sample images at the moment).
I have deployed the fix to the indicia-team client_helpers timed counts form (again the problem is theoretical, as this form does not use sample images at the moment)
I have deployed to the older version of the EBMS data entry form, I don't think this form is in use anymore but have deployed the fix just in case it is used in a place I am unaware of.
I left the SPRING project alone (which is no longer under active development). That project does in theory have the same problem, but in reality it is unaffected as sample media is not used on its transects form.

@CrisSevilleja
Please close this if you are happy with the fix.