Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gffstring can still merge reverse strand multi-position loci #16

Closed
ian-small opened this issue Nov 13, 2024 · 1 comment
Closed

gffstring can still merge reverse strand multi-position loci #16

ian-small opened this issue Nov 13, 2024 · 1 comment

Comments

@ian-small
Copy link

Thanks for the very rapid fix, but it's not quite complete. 'if locus(gene) isa Union{Join, Order}' fails for loci constructed as Complement(Join([Locus, Locus])). I can work round this by constructing all such features as Join([Complement(Locus), Complement(Locus)]) (in which case everything works perfectly as far as I can see), but you might not want to rely on features always being constructed that way.

@kdyrhage
Copy link
Member

Good catch. The following commit should fix the immediate issue, but I will try to find a more elegant solution.

Do note that complement(join(1..10,20..30)) and join(complement(1..10),complement(20..30)) are not equal, though:

s = dna"ATGCGCTAA"
println(sequence(s, Locus("join(complement(1..3),complement(7..9))")))
println(sequence(s, Locus("complement(join(1..3,7..9))"))

returns

CATTTA
TTACAT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants