Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX lucene search form tweaks #206

Open
13 of 14 tasks
hextraza opened this issue Jul 5, 2023 · 3 comments
Open
13 of 14 tasks

UI/UX lucene search form tweaks #206

hextraza opened this issue Jul 5, 2023 · 3 comments

Comments

@hextraza
Copy link
Contributor

hextraza commented Jul 5, 2023

  • Hidden/unhidden columns reset on filtration
  • Rename "Filter" to "Search"
  • Add a filter state button for searchString=all
  • Loading circle during queries
  • None values in filter form can lead to odd behavior
  • Going from "in-set" to another operator doesn't immediately reset the select box
  • ExternalVariantWidget Dialog needs margin/better styling
  • is empty/is not empty should not allow for an entered value
  • Make forward/backward consistently rerender the table
  • CADD_PH treated as string
  • For the start/end/position columns, add a JEXK format string to format with commas. Ensure the grid adds a valueFormatter or some similar hook to use this. Ensure the result sorts correctly (i.e. sorts on the raw value, not formatted string). There is a stub here:
    // TODO: can we pass the JEXL format string here? How does this impact filter/sorting?
  • Make header tooltip text 8px->18px
  • variableSamples value is truncated when filter is applied on Filter form (not on the filter status button)
  • Create a function for "serializeLocationToLuceneQuery", which takes the location (contig/start/end) and write that into a string that we could append to the URL. Then use this in the URL generated by the Variant Table button for "change to free-text search"
@bbimber
Copy link
Contributor

bbimber commented Jul 20, 2023

This is not strictly lucene, but if we're going to keep the original table widget, we should fix the styling on value:
image

Example test URL: http://localhost:8080/labkey/home/jbrowse-variantTable.view?session=mgap&trackId=mgap_hg38&location=1:1..430419

@bbimber
Copy link
Contributor

bbimber commented Jul 25, 2023

More on that styling. In the screenshot below, if I disable the marginDense margin-top:8px directive, it fixes the misalignment. Unsure if this is actually the best place to edit, but maybe this gives a clue what to update:
image

@bbimber
Copy link
Contributor

bbimber commented Jul 27, 2023

This styling issue is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants