From f56d273aacbb3c1d05593eb3de9fb6634c735580 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Mon, 14 Feb 2022 14:20:43 -0500 Subject: [PATCH] acme/autocert: skip renewal tests broken on windows/arm64 For golang/go#51080 Change-Id: Icf4414ab58bdea44b793a66770b4c05f9faf5387 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/385675 Trust: Bryan Mills Run-TryBot: Bryan Mills Reviewed-by: Jeremy Faller TryBot-Result: Gopher Robot --- acme/autocert/renewal_test.go | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/acme/autocert/renewal_test.go b/acme/autocert/renewal_test.go index ffe4af2a5c..460a384255 100644 --- a/acme/autocert/renewal_test.go +++ b/acme/autocert/renewal_test.go @@ -8,6 +8,7 @@ import ( "context" "crypto" "crypto/ecdsa" + "runtime" "testing" "time" @@ -42,6 +43,15 @@ func TestRenewalNext(t *testing.T) { } func TestRenewFromCache(t *testing.T) { + if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" { + // This test was observed to fail frequently in Dial with "connectex: No + // connection could be made because the target machine actively refused it." + // + // Failures started around CL 381715, so it looks to me (bcmills) like an + // undiagnosed bug in (or exposed by) acmetest.CAServer. + t.Skipf("skipping test on windows/arm64: see https://go.dev/issue/51080") + } + man := testManager(t) man.RenewBefore = 24 * time.Hour @@ -127,6 +137,15 @@ func TestRenewFromCache(t *testing.T) { } func TestRenewFromCacheAlreadyRenewed(t *testing.T) { + if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" { + // This test was observed to fail frequently in Dial with "connectex: No + // connection could be made because the target machine actively refused it." + // + // Failures started around CL 381715, so it looks to me (bcmills) like an + // undiagnosed bug in (or exposed by) acmetest.CAServer. + t.Skipf("skipping test on windows/arm64: see https://go.dev/issue/51080") + } + ca := acmetest.NewCAServer(t).Start() man := testManager(t) man.RenewBefore = 24 * time.Hour