Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t3f.round() does not support epsilon #202

Open
aiboyko opened this issue Dec 17, 2019 · 1 comment
Open

t3f.round() does not support epsilon #202

aiboyko opened this issue Dec 17, 2019 · 1 comment

Comments

@aiboyko
Copy link

aiboyko commented Dec 17, 2019

As opposed to TT-Toolbox and TTPY package, round() with a given epsilon, does not actually lead to a reduction of the rank for a function it is supposed to work with.

I tested on np.exp(-x*y) function projected on a uniform grid.
In ttpy, this function has rank=8 if eps=1e-14, and rank=3 if eps=1e-3 .

However, when I create t3f TT using:
T3FZ = t3f.to_tt_tensor(Z)

it automatically leads to rank=10.
After t3f.round(tt=T3FZ, eps=1e-3) rank is still 10.

Having to convert t3f TT on GPU intro ttpy TT just to be able to do rounding with a given EPS is not convenient, could you please fix the round() function?

@Bihaqo
Copy link
Owner

Bihaqo commented Dec 17, 2019

Oh, yes, epsilon is not supported (you're the first one to need it).

I can do it, but probably not this week. You're welcome to to it yourself though, I can help :)

@Bihaqo Bihaqo changed the title t3f.round() does not work t3f.round() does not support epsilon Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants