Fix axis limits not set correctly upon redrawing #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 90.66% 90.77% +0.11%
==========================================
Files 7 7
Lines 621 629 +8
==========================================
+ Hits 563 571 +8
Misses 58 58 ☔ View full report in Codecov by Sentry. |
Add a margin of 5% to the xlimits and ylimits of the plot upon redraw * Modify `Scatter` class in `src/biaplotter/artists.py` to add a margin of 5% to the xlimits and ylimits in the `data` property setter. * Modify `Histogram2D` class in `src/biaplotter/artists.py` to add a margin of 5% to the xlimits and ylimits in the `data` property setter. * Update tests in `src/biaplotter/_tests/test_artists.py` to verify that the xlimits and ylimits include a margin of 5% beyond the minimum and maximum values of the data. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/BiAPoL/biaplotter/pull/25?shareId=11a0d7b2-c389-46cd-a8fb-9e810aeb76dd).
|
Hi @jo-mueller , That makes sense for the scatter plot, but maybe not for the histogram, what do you think? Take a look at the comparisons below: Scatter before current changes: Scatter after current changes: Histogram before current changes: Histogram after current changes: |
|
uh....good point. I'll remove it from the histogram |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
Update
ScatterandHistogram2Dclasses to set axis limits based on data.datasetter method to set x and y axis limits based on the data.datasetter method to set x and y axis limits based on the data.Scatterclass.Histogram2Dclass.For more details, open the Copilot Workspace session.