Correct setting.find_or_default to do what it says #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous "setting ||= find_by_name(name)" line failed to load settings (only overwrote the setting if it did not contain a default - a condition guaranteed by the previous conditional to never occur)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous "setting ||= find_by_name(name)" line failed to load settings (only overwrote the setting if it did not contain a default - a condition guaranteed by the previous conditional to never occur)
"||=" is "set value if not already set" not "set value if right side isn't nil". There's probably a more graceful way to do this that doesn't involve pulling the setting -twice-, but I'm brand new to Ruby and have no idea how to do that. :)