Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish API docker image with multi-platform support #332

Closed
djperrefort opened this issue Jul 9, 2024 · 1 comment
Closed

Publish API docker image with multi-platform support #332

djperrefort opened this issue Jul 9, 2024 · 1 comment
Assignees

Comments

@djperrefort
Copy link
Member

Add linux/amd64 and linux/arm64 at a minimum.

@djperrefort
Copy link
Member Author

The CI pipeline for this project builds the docker image(s) at the beginning of each run and writes the result to GHA artifact storage for use in later CI stages. In regards to multi-platform builds, this raises a problem.

Docker supports saving containers/images to disk in various formats. As of right now, the default "docker" format does not support multi-platform builds, forcing us to switch to the OCI format instead. Unfortunately, docker uses it's "export" feature to write OCI images instead of it's "save" feature. The relevant difference here is that "export" creates a container snapshot and omits crucial metadata and build directives like CMD - all things we need to preserve in the published image.

After looking at related issues, we're not the only one's facing this problem. A common work around is to build the images separately and combine them later via a manifest. However, this gets messy to implement within our current CI architecture.

Here is a similar issue with a well thought out description: fiaas/fiaas-deploy-daemon#179

With all of this in mind, I'm marking this as "not planned" for now. I'm happy to revisit if/when docker makes things easier.

Ping @yassinkhalifa so he is aware.

@djperrefort djperrefort closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant