Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions fail in v1.17.18 #219

Closed
svg153 opened this issue Jun 6, 2022 · 3 comments
Closed

Actions fail in v1.17.18 #219

svg153 opened this issue Jun 6, 2022 · 3 comments
Assignees
Labels
bug Something isn't working released resolved Issue or question was resolved/answered

Comments

@svg153
Copy link
Contributor

svg153 commented Jun 6, 2022

🐞 Describe the bug

After this merge, our workflows failed.
Look at the screenshots.

📚 To Reproduce

  • Having a working configuration
  • Update the action version to v1.17.18
  • Run the sync workflow

💡 Expected behavior

Works like version v1.17.17

🖼️ Screenshots

Action trace screenshot

failed

As seen in the commit screenshot.

commit

  • We made a change in PR-110. We added the variable BRANCH_PREFIX: 'admin/sync/actions' for the Sync common GitHub Actions workflow, but as you can see, all of them failed, not just the modified workflow.
  • We made a PR-111 to put the version v1.17.17 and everything worked fine.

⚙️ Environment

📋 Additional context

  • After the rollback to version v1.17.17 everything worked fine.
  • cc: @gomete
@svg153 svg153 added the bug Something isn't working label Jun 6, 2022
@etremblay
Copy link

We have the same issue

@BetaHuhn BetaHuhn added the investigating Issue is being investigated label Jun 7, 2022
@BetaHuhn BetaHuhn self-assigned this Jun 7, 2022
@BetaHuhn
Copy link
Owner

BetaHuhn commented Jun 7, 2022

Thanks for reporting this @svg153!

Issue should be fixed in v1.17.19. Please let me know if the error is resolved on your end.

The issue was caused by an automated dependency upgrade, specifically node-readfiles v0.3.0. To mitigate such an issue from disrupting the use of this action in the future I have disabled all automatic dependency updates for now. I will keep it disabled until we have near 100% test coverage of this action (currently we have none).

I think this is a good opportunity to think about adding tests to this project, if anyone has recommendations on how to do this, please let me know! Also happy to accept contributions if anyone wants to work in this themselves. I created discussion #220 to discuss this further.

Thanks!

@BetaHuhn BetaHuhn added resolved Issue or question was resolved/answered and removed investigating Issue is being investigated labels Jun 7, 2022
@svg153
Copy link
Contributor Author

svg153 commented Jun 7, 2022

It works again with the master version 👍 ❤️

Thanks :)

PD: For us, this issue would be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released resolved Issue or question was resolved/answered
Projects
None yet
Development

No branches or pull requests

3 participants