Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect site type icons for Canopeum and Farms Land #272

Closed
Samuel-Therrien-Beslogic opened this issue Oct 24, 2024 · 0 comments · Fixed by #327
Closed

Incorrect site type icons for Canopeum and Farms Land #272

Samuel-Therrien-Beslogic opened this issue Oct 24, 2024 · 0 comments · Fixed by #327

Comments

@Samuel-Therrien-Beslogic
Copy link
Contributor

Samuel-Therrien-Beslogic commented Oct 24, 2024

As mentioned in #270 and #271:

https://www.npmjs.com/package/material-icons does not support custom icons.
Since we already use https://www.npmjs.com/package/@mui/material, we could consider https://www.npmjs.com/package/@mui/icons-material .

For the short term, we're using incorrect, but still unique, icons for "Canopeum" and "Farms Land".

We need to be able to use custom icons for those two site type. Preferably by registering svgs as icons to work with the rest of the system. But if we really have to, a custom higher-order component for rendering site type icons may do.

Similarly, the map pins would be preferable as generic pins that can take any icon

(see the linked PRs for code location)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant