Check only for real island members when creating warps

[wellnesscookie]

Description
Players that were cooped or trusted succeeded in creating a warp sign on others people islands. We haven't tested for visitors (With block-placement allowed), but it would be nice if only real team members could be allowed to set a warp sign on their island.

One of the problems this caused was that they were unable to break the warp while the owner or warp-creator was absent.

Steps to reproduce the behavior:

1. Go on an island where you are cooped/ trusted
2. Place a warp

Expected behavior
Not be able to place a warp

Server Information:

• Database being used: mySQL
• OS: Linux/ Debian GNU 9
• Java Version: Java 10
• BentoBox version: 1.6.0 - SNAPSHOT b1241
• Addons installed:

 BSkyBlock 1.5.0
 AcidIsland 1.5.0
 Welcome-warp sign 1.5.0
 others are not relevant

• Other plugins:
  Not relevant

Additional context

• Still not sure if visitors with specific flags would be able to place them too

[wellnesscookie]

I'm turning this issue into a feature request now too. Would it be possible to make a flag managable via /is settings to allow people to place those warp signs? This actually took a role with our economy. Non-rank players bought "warps" from ranked ones. Scamming is allowed of course, but we've got many nice people that wouldn't do so.

I'd like to hear to know if some1 thinks too that this is a good idea or at least change my mind if it's not.

[tastybento]

Interesting. What i’m hearing is that you do want to allow warps on other islands. I think that it should be possible to change the break checking so that a player can break their own signs. Also, I can have signs auto remove if a player loses their rank status on an island.

[wellnesscookie]

Okay, yes, but I'd like to receive more opinions, I'm not so sure. Our players figured out 2 days ago for the exploit of making warps on island that you are not a real member of.

What's your opinion? And about the removing sign... hm, well that would be totally fine I guess.

Sorry to ask here: Tho is it possible to remove a warp sign if the player loses its permission for it? We had to hook with an additional addon made by us to listen to luckperms and break it. Not sure if this feature is present at all, but if is then it's not working. At least if it could perform a check on server restart?