-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heightfield() arguments should parallel texturing arguments in cyl, linear_sweep, rotate_sweep, etc. #1346
Comments
It seems the heightfield() produces results rotated 90 deg from texture(), which is not great. |
Oh, actually style means exactly the same thing to heightfield as it does to texture: it's just passed through to vnf_vertex_array. |
Actually heightfield is transposing the data, not rotating. I think that what needs to happen is heightfield is deprecated and replaced by a module that applies a texture to the top face of a cuboid. Not sure what it should be called. This new module would accept the usual texturing args and would not transpose the data like heightfield does. There could be extra args to truncate heightfields or scale them to [0,1], I suppose. |
Could it be just extending cuboid() to allow textures and specify where with "faces = " much like rounding is specified with "edges = " ? |
How would that interoperate with chamfers and roundings? Or would it be mutually exclusive? I was vaguely thinking about something that did one face of a cuboid and you could then attach() it to other objects where desired. Another issue with multi-face support would be controlling rotation of each face. |
I hadn't thought that through completely. But if you're texturing one face, you still have the same issue don't you? |
If you're texturing one face you can rotate the texture before you put it on. And if you're attaching a texture to several faces, you can rotate each one individually as needed. |
A heightfield attached to the top of a cuboid will fail an F6 render unless bottom < 0. |
Heightfield uses an argument list quite different from other texturing modules.
tex_depth, tex_size, tex_reps, tex_inset would all be useful in heightfield.
"style" seems to mean different things in heightfield() vs cyl(), etc.
The text was updated successfully, but these errors were encountered: