Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handeling on donations form is not ideal. #41

Open
TheGrandVizier opened this issue Sep 6, 2017 · 3 comments
Open

Error handeling on donations form is not ideal. #41

TheGrandVizier opened this issue Sep 6, 2017 · 3 comments
Assignees
Milestone

Comments

@TheGrandVizier
Copy link

http://prntscr.com/ght7y2

the little red mark seen in the picture above is the only indicator of what is wrong with the users input.

For other fields, there is not even that indicator.
If a mandatory field is left unfilled, user must find it manually.

@ibanner ibanner assigned ibanner and unassigned ibanner Sep 6, 2017
@ibanner
Copy link
Contributor

ibanner commented Sep 7, 2017

@TheGrandVizier Which browser were you using? all the required fields are marked as such and supposed to have HTML5 validation messages when left blank. However I can see that the validation message that should appear over the terms & conditions checkbox isn't displayed properly. In the console I see some error message related to an event triggered on Facebook.

@nirgoldberg is there any global "onsubmit" even that's causing this conflict?

@ibanner
Copy link
Contributor

ibanner commented Sep 10, 2017

@nirgoldberg I get this error in the console when I try to submit the form - any idea where this comes from?

image

@TheGrandVizier TheGrandVizier added this to the Pergamon milestone Sep 17, 2017
@TheGrandVizier TheGrandVizier changed the title Error handeling on donations for is not ideal. Error handeling on donations form is not ideal. Sep 18, 2017
@ibanner
Copy link
Contributor

ibanner commented Aug 19, 2018

@TheGrandVizier I know there's an issue with the checkboxes (as the displayed element is not really the native checkbox control) - but can you please re-check if you still have validation issues on the "regular" fields (text and drop-downs)? My own testing showed that these fields display the browser's native validation tool-tips.

If I'm right, then all is left to do it so display a custom validation error message. I just want to double check before I go on with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants