New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should ensure duplicate slugs are handled correctly #74

Open

OriHoch opened this issue Aug 2, 2017 · 0 comments

Labels

bug clearmash help wanted

Contributor

OriHoch commented Aug 2, 2017

reproduction

sync 2 items with the same title (which causes slug conflict)

expected

1st item to be scraped will get the normal slug
2nd item will get a modified slug to prevent conflict
- need to ensure the modified slug is the only one for this item

actual

the 2nd item gets the modified slug along with the normal slug which is set also on the 1st item
causing slug conflict

implementation notes

it might happen if both items are synced in the same processor (so ES is not updated yet)
or possibly, other case where ES is not updated soon enough
or, might be just a bug in code

OriHoch added bug clearmash help wanted labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment