Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Research: how to get main image from clearmash? #51

Open
Libisch opened this issue Jul 12, 2017 · 8 comments
Open

[Task] Research: how to get main image from clearmash? #51

Libisch opened this issue Jul 12, 2017 · 8 comments

Comments

@Libisch
Copy link
Contributor

Libisch commented Jul 12, 2017

Varify that the first related image (see #25 to get related docs/items):

  • In Clearmash, open a random place, photo, personality and family name that have a more than one photo, for example: Albert Einstein (Personality), New York City (Place).
  • Call api for related photos
  • Check if the first photo document is the cover image of the item in clearmash

Related:
#25 [Task] research how images data is represented in Clearmash
#23 sync should populate main_image_url and main_thumbnail_image_url fields

@Libisch Libisch self-assigned this Jul 12, 2017
@Libisch Libisch removed their assignment Jul 12, 2017
@OriHoch OriHoch changed the title [Task] Research main image [Task] Research: how to get main image from clearmash? Jul 12, 2017
@Libisch Libisch self-assigned this Jul 18, 2017
@Libisch
Copy link
Contributor Author

Libisch commented Jul 18, 2017

@omrisuissa
Is there any indication for main image of an item? Also, in case of a related photo being a photoUnit containing more that on photo - how is the main image determined?

comparing the documents and the way they are presented in Clearmash CMS, I found these examples:

  1. for Einstein Albert (personality), 202567 - the main(?) image is the second (and last) listed in item's related documents field. The first related doc contains more than one photo, does that effect the priority?
  2. for item 115353 (place), there are two photos presented in the same order as they are in related documents field.

Any other information regarding this issue would be appreciated.
Thanks

@ghost
Copy link

ghost commented Jul 18, 2017

You should see a field named bh_base_template_mg_items_main_image (or similar name) that indicates if this is the main image in the photo unit.
the first unit that related is the main photo unit in the following order: image, video, sound

@Libisch
Copy link
Contributor Author

Libisch commented Jul 19, 2017

Thanks @omrisuissa.
@OriHoch - I can't find this field anywhere... any idea?

@Libisch
Copy link
Contributor Author

Libisch commented Jul 19, 2017

Moved to #62

@OriHoch
Copy link
Contributor

OriHoch commented Jul 25, 2017

@Libisch - what's the status of this issue?
if it moved to #62 , can this issue be closed?
what else is needed to do for this issue?

@Libisch
Copy link
Contributor Author

Libisch commented Jul 25, 2017

Moved, closing.

@Libisch Libisch closed this as completed Jul 25, 2017
@Libisch Libisch reopened this Jul 25, 2017
@Libisch
Copy link
Contributor Author

Libisch commented Jul 25, 2017

@omrisuissa Could you please give us an example for an item in which a main_image is indicated? Some items where checked by calling get_documents and get_related_by_field, but none contained the field 'bh_base_template_mg_items_main_image' (or a similar name).

@ghost
Copy link

ghost commented Aug 2, 2017

I'll try to find an example for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants