Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing fields in the places #195

Closed
Netush opened this issue Jun 22, 2017 · 2 comments
Closed

Missing fields in the places #195

Netush opened this issue Jun 22, 2017 · 2 comments

Comments

@Netush
Copy link

Netush commented Jun 22, 2017

Places item should presented the user images attach (if have), need to be presented on a map - precise location & need to show related links if Editors put it manually.
Need to understand which of this fields can provide all of this data
It might be in one of this fields:
Images attach:
Attachments or PrevPictureFileNames or PrevPicturePaths or PictureUnitsIds or Pictures
Map coordinates:
geometry.coordinates
also might need PlaceParentTypeCodeDesc.En & PlaceTypeCode & PlaceTypeDesc.En & PlaceTypeDesc.He
(this data provide us what kind of a place is it - city / country / town...)
Related:
related

Also need to know the display status
It can be in one of this fields:
DisplayStatusDesc or RightsCode or UnitDisplayStatus or ForDisplay or RightsDesc

@Libisch
Copy link
Contributor

Libisch commented Jun 22, 2017

@Netush
Existing open issues for images:

  1. [Task] research how images should be handled from Clearmash #21
  2. should get images data from clearmash api #24
  3. sync should populate main_image_url and main_thumbnail_image_url fields #23

Existing open issue for Location:

sync should add location field with lat/long #16

This issue will be updated to include research - should we add geodata just for Places, or wherever possible (even if not for maps or current usage):

  • Persons places (birth, marriage, death)
  • PhotoUnits (if in title ot in related places, etc.)

@OriHoch
Copy link
Contributor

OriHoch commented Jul 10, 2017

closing this issue, as @Libisch wrote it is handled in other issues

feel free to re-open if you think there is something not handled / something is missing from the other issues

@OriHoch OriHoch closed this as completed Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants