Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

general search persons - general search query should search in all person fields #181

Closed
OriHoch opened this issue Jun 5, 2017 · 3 comments
Closed

general search persons - general search query should search in all person fields #181

OriHoch opened this issue Jun 5, 2017 · 3 comments
Assignees
@TheGrandVizier

Comments

@OriHoch
Copy link
Contributor

OriHoch commented Jun 5, 2017

preconditions

reproduction steps

expected

  • should return the person
  • API should search in all relevant text fields

actual

  • no results
  • this is because currently API searches only in first / last name fields
@OriHoch OriHoch mentioned this issue Jun 5, 2017
Closed
@OriHoch
Copy link
Contributor Author

OriHoch commented Jun 5, 2017

implementation notes

@Libisch Libisch self-assigned this Jun 5, 2017
@Libisch
Copy link
Contributor

Libisch commented Jun 7, 2017

Done. See #182

@Libisch Libisch mentioned this issue Jun 7, 2017
Merged
@OriHoch OriHoch mentioned this issue Jun 7, 2017
Closed
@OriHoch
Copy link
Contributor Author

OriHoch commented Jun 8, 2017

deployed to test

@OriHoch OriHoch assigned TheGrandVizier and unassigned Libisch Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheGrandVizier TheGrandVizier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@OriHoch @TheGrandVizier @Libisch