Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write documentation for 'suggestions' #161

Open
Inna-r opened this issue May 9, 2017 · 5 comments
Open

Write documentation for 'suggestions' #161

Inna-r opened this issue May 9, 2017 · 5 comments
Assignees

Comments

@Inna-r
Copy link
Contributor

Inna-r commented May 9, 2017

@OriHoch
Copy link
Contributor

OriHoch commented May 9, 2017

@Libisch - I think it's worth you do it, to familiarize yourself with both the suggest API and the documentation

it should be very simple, talk to me to see how to do it

@Libisch
Copy link
Contributor

Libisch commented May 12, 2017

@OriHoch
Done, according to current suggestions on TEST - The API returns a response but it's not yet implemented in the general search box (front-end).

  • Added documentation for suggestions includes general search box suggestions, and wizard search boxes suggestions (familyNames and places).
  • Please review here (I haven't created a pull request in case this doesn't answer the requirements).

@OriHoch
Copy link
Contributor

OriHoch commented May 15, 2017

@Libisch please open a pull request to review it

@OriHoch
Copy link
Contributor

OriHoch commented May 15, 2017

BTW, it should work on production as well
frontend is not relevant for this issue

@OriHoch
Copy link
Contributor

OriHoch commented May 15, 2017

opened an issue with some problems I saw on test environment: #168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants