Additional XML verification for Control nodes

BehaviorTree · Nov 20, 2024 · 8e12e3b · 8e12e3b
1 parent 2bc72fd
commit 8e12e3b
Showing 1 changed file with 19 additions and 0 deletions.
diff --git a/src/xml_parsing.cpp b/src/xml_parsing.cpp
@@ -536,6 +536,25 @@ void VerifyXML(const std::string& xml_text,
       }
       else if(search->second == NodeType::CONTROL)
       {
+        if (name == "Sequence" && children_count <= 2)
+        {
+          ThrowError(line_number,
+                     std::string("A Sequence node must have 2 or more children"));
+        }
+        else if (name == "ReactiveSequence" && children_count <= 2)
+        {
+          ThrowError(line_number,
+                     std::string("A ReactiveSequence node must have 2 or more children"));
+        }
+        if (name == "ReactiveSequence")
+        {
+          auto first_child_node = search->second.FirstChildElement();
+          if (first_child_node != NodeType::CONDITION)
+          {
+            ThrowError(line_number,
+                      std::string("The first child of a ReactiveSequence should be of Condition type"));
+          }
+        }
         if(children_count == 0)
         {
           ThrowError(line_number,