Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Alternative default bastille_zfs_prefix #713

Open
MamoruDS opened this issue Jul 19, 2024 · 1 comment
Open

[ENHANCEMENT] Alternative default bastille_zfs_prefix #713

MamoruDS opened this issue Jul 19, 2024 · 1 comment
Assignees

Comments

@MamoruDS
Copy link

Is your feature request related to a problem? Please describe.

The current default value of bastille_zfs_prefix has been changed(#711) to ${bastille_zfs_zpool}/bastille. Since all the scripts use ${bastille_zfs_zpool}/${bastille_zfs_prefix} as the dataset path prefix, this causes a duplication of bastille_zfs_zpool (which will be zroot/zroot/bastille after setup without any modification).

Describe the solution you'd like

To avoid this issue, manually change the config value of bastille_zfs_prefix to an arbitrary value (e.g., the previous bastille). Reverting to bastille as the default may provide a smoother experience.

Additional context

An example in bootstrap.sh shows the script using ${bastille_zfs_zpool}/${bastille_zfs_prefix} as the dataset path:

https://github.com/BastilleBSD/bastille/blame/cee6f20aa5c228e7e4791bc9d0fcdc412bab71ae/usr/local/share/bastille/bootstrap.sh#L150

@yaazkal
Copy link
Collaborator

yaazkal commented Oct 30, 2024

Thanks for the comment and the workaround, I'm gonna take this

@yaazkal yaazkal self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants