Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle SIGTERM signal #1

Closed
Bassetts opened this issue May 16, 2020 · 0 comments · Fixed by #4
Closed

Handle SIGTERM signal #1

Bassetts opened this issue May 16, 2020 · 0 comments · Fixed by #4
Assignees
@Bassetts
Milestone
0.2

Comments

@Bassetts
Copy link
Owner

Currently SIGTERM is not handled, this means Docker can't gracefully shutdown warp-cors and ends up sending SIGKILL. Use bind_with_graceful_shutdown so we can handle SIGTERM and allow Docker to gracefully stop the server.
@Bassetts Bassetts added this to the 0.2 milestone May 17, 2020
@Bassetts Bassetts self-assigned this May 18, 2020
@Bassetts Bassetts mentioned this issue Jun 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bassetts Bassetts

Labels
None yet
Projects
None yet
Milestone
0.2
Development

Successfully merging a pull request may close this issue.

Add signal handlers Bassetts/warp-cors
1 participant
@Bassetts