Fix computing video view's width and height when using padding

[saghul]

According to the MDN docs the padding is included, so substract it.

[saghul]

/cc @ibc

[hthetiot]

lgtm

[ibc]

Question: how does this work? The video width/height is modified based on the CSS padding, but I do not see the X/Y position of the video being updated. Do I miss something?

[ibc]

I mean: do elementLeftetc properly point to the position of the video?

[ibc]

To be clear:

elementLeft is the left value retrieved from:

function getElementPositionAndSize() {
    var rect = this.element.getBoundingClientRect();

    return {
        left:   rect.left + this.element.clientLeft,
        top:    rect.top + this.element.clientTop,
        width:  this.element.clientWidth,
        height: this.element.clientHeight
    };
}

My concern is: If a <video> element has padding, where is left points to?

getBoundingClientRect() "returns a TextRectangle object that includes the padding, scrollbar, and the border, but excludes the margin":

• http://help.dottoro.com/ljvmcrrn.php

That's the reason of my worry.

[saghul]

Yep, forgot to take care of that. Will test and fix.
On Nov 22, 2015 5:50 PM, "Iñaki Baz Castillo" [email protected]
wrote:

To be clear:

elementLeft is the left value retrieved from:

function getElementPositionAndSize() {
var rect = this.element.getBoundingClientRect();

return {
    left:   rect.left + this.element.clientLeft,
    top:    rect.top + this.element.clientTop,
    width:  this.element.clientWidth,
    height: this.element.clientHeight
};

}

My concern is: If a

getBoundingClientRect() "returns a TextRectangle object that includes the
padding, scrollbar, and the border, but excludes the margin":

• http://help.dottoro.com/ljvmcrrn.php

That's the reason of my worry.

—
Reply to this email directly or view it on GitHub
#89 (comment)
.

[saghul]

@ibc Fixed and tested, can you PTAL?

[ibc]

Cannot check it now, but:

Padding is not added to te CSS width/height when box-sizing is "border-box" and may be other values, so this would need even more work:

https://developer.mozilla.org/es/docs/Web/CSS/box-sizing

[saghul]

box-sizing is not currently supported by the plugin AFAIK, so that would be another patch/improvement IMHO. This patch just adds support for padding-* to the current set of supported properties.