Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updating dependencies and library tools/languages versions #96

Merged
merged 14 commits into from
Oct 31, 2023
Merged

feat: updating dependencies and library tools/languages versions #96

merged 14 commits into from
Oct 31, 2023

Conversation

jleon15
Copy link
Contributor

@jleon15 jleon15 commented Oct 9, 2023 •
edited
Loading

Description

⚠️ :

  • compose ui version (1.3.2 -> 1.5.3)
  • android gradle plugin (7.3.1 -> 8.1.2)
  • kotlin gradle plugin (1.8.21 -> 1.9.10)
  • removing classifier from snakeyaml transitive dependency from javafaker, since new 2.x versions don't include the jar for the android classifier
  • gradle version (7.4 -> 8.4)
  • android sdk compile and target (32 -> 34)
  • JDK compile version from 8 to 17

Testing required outside of automated testing?

  • Not Applicable

Screenshots (if appropriate):

  • Not Applicable

Rollback / Rollforward Procedure

  • Roll Forward
  • Roll Back

Reviewer Checklist

  • Description of Change
  • Description of outside testing if applicable.
  • Description of Roll Forward / Backward Procedure
  • Documentation updated for Change

@jleon15 jleon15 requested a review from a team as a code owner October 9, 2023 14:41
dhudec
dhudec previously approved these changes Oct 9, 2023
View reviewed changes
@jleon15 jleon15 changed the title feat: updating dependencies feat: updating dependencies and library tools/languages versions Oct 12, 2023
dhudec
dhudec reviewed Oct 19, 2023
View reviewed changes
example/src/androidTest/java/com/basistheory/android/example/CollectCustomFormTests.kt Outdated
@@ -54,7 +54,7 @@ class CollectCustomFormTests {
}

@Test
fun canTokenize() {
fun ÏcanTokenize() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this an accidental change?

dhudec
dhudec previously approved these changes Oct 19, 2023
View reviewed changes
@jleon15 jleon15 merged commit 9433d32 into master Oct 31, 2023
4 checks passed
@jleon15 jleon15 deleted the eng-5448-update-dependencies branch October 31, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhudec dhudec dhudec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleon15 @dhudec