feat: adds bt http client #74
Conversation
kevinperaza
force-pushed
the
adds-http-client
branch
4 times, most recently
from
8953130 to
5964f1b
Compare
kevinperaza
force-pushed
the
adds-http-client
branch
from
5964f1b to
2787290
Compare
kevinperaza
force-pushed
the
adds-http-client
branch
from
2787290 to
110a07f
Compare
| send(url, HttpMethod.DELETE, null, headers) | ||
| } | ||
|
|
||
| private fun requestBuilder( |
There was a problem hiding this comment.
I would rename this to buildRequest since it is building it already
| </LinearLayout> | ||
|
|
||
|
|
||
| <TextView |
There was a problem hiding this comment.
what's the difference between payment_method and result
There was a problem hiding this comment.
Removed payment_method
| val foo = "bar" | ||
| } | ||
|
|
||
| server.enqueue(MockResponse().setBody("Everything is broken").setResponseCode(500)) |
There was a problem hiding this comment.
does it really returns 500? it feels like we should return 400
There was a problem hiding this comment.
This is just MockedWebServer; it could return anything you want and in this test we're just making sure we throw when using unsupported content-types in the request; we don't have control over the responses from the 3rd-parties anyways
There was a problem hiding this comment.
but if they provide a content type that the client doesn't support does it return 500?
| val request = server.takeRequest() | ||
| assertEquals("POST", request.method) | ||
| assertEquals(endpoint, request.path) | ||
| assertEquals(expectedRequestBody, request.body.readUtf8()) |
There was a problem hiding this comment.
can you assert on the response of all of these?
There was a problem hiding this comment.
Yes, I can. Do you see any value tho? Or is there anything in particular you'd like to see? Because it's pretty much the same as above
There was a problem hiding this comment.
in which one are you asserting the response?
There was a problem hiding this comment.
just to make sure nothing is updating the response and we get what we expect
| // RequestBody appends the charset by default | ||
| assertEquals(expectedRequestBody.contentType(), "$contentType; charset=utf-8".toMediaType()) | ||
| assertEquals(expectedRequestBody.contentLength(), requestBody?.contentLength()) | ||
|
|
There was a problem hiding this comment.
can you remove these extra lines
| import java.io.IOException | ||
|
|
||
| class DualWriteUtilsTests { | ||
| private val faker = Faker() |
There was a problem hiding this comment.
are you using this anywhere?
There was a problem hiding this comment.
I am not; removed.
Description
Testing required outside of automated testing?
Screenshots (if appropriate):
Rollback / Rollforward Procedure
Reviewer Checklist