feat: Publishes change event from CardVerificationCodeElement on brand changes #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleon15
reviewed
Jan 5, 2023
| // change the card brand from visa to american-express | ||
| cardNumberElement.setText("4242424242424242") | ||
|
|
||
| expectThat(cvcElement.getText()).isEqualTo("1234") // value does not change |
There was a problem hiding this comment.
so it is their problem to make sure it is not tokenized like this since the element still have 4 digits right?
jleon15
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the card number is changed resulting in a card brand change with a different mask length, we now emit an additional event from the the CVC element with updated validation/completion states.
Testing required outside of automated testing?
Screenshots (if appropriate):
Rollback / Rollforward Procedure
Reviewer Checklist